chore(deps): bump the actions-deps group with 4 updates#41
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
chore(deps): bump the actions-deps group with 4 updates#41dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps the actions-deps group with 4 updates: [@actions/artifact](https://github.com/actions/toolkit/tree/HEAD/packages/artifact), [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core), [@actions/github](https://github.com/actions/toolkit/tree/HEAD/packages/github) and [@actions/glob](https://github.com/actions/toolkit/tree/HEAD/packages/glob). Updates `@actions/artifact` from 2.3.2 to 6.2.0 - [Changelog](https://github.com/actions/toolkit/blob/main/packages/artifact/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/artifact) Updates `@actions/core` from 1.11.1 to 3.0.0 - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) Updates `@actions/github` from 6.0.1 to 9.0.0 - [Changelog](https://github.com/actions/toolkit/blob/main/packages/github/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/github) Updates `@actions/glob` from 0.5.0 to 0.6.1 - [Changelog](https://github.com/actions/toolkit/blob/main/packages/glob/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/glob) --- updated-dependencies: - dependency-name: "@actions/artifact" dependency-version: 6.2.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: "@actions/core" dependency-version: 3.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: "@actions/github" dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: "@actions/glob" dependency-version: 0.6.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com>
| @@ -13,10 +13,10 @@ | |||
| }, | |||
| "packageManager": "pnpm@10.15.0", | |||
| "dependencies": { | |||
There was a problem hiding this comment.
Bug: The call to uploadArtifact uses an outdated function signature for the new library version, passing a directory path string instead of the expected options object.
Severity: CRITICAL
Suggested Fix
Update the uploadArtifact call to match the new API signature. The third argument should be an options object. If the intention was to specify a root directory, that logic needs to be adapted, as the new API does not support a rootDirectory parameter in the same way. The files in the second argument should be provided as absolute paths.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L15
Potential issue: The code calls `this.artifactClient.uploadArtifact()` with three
positional arguments: `artifactName`, `[resultsFile]`, and `tmpDir`. The update to
version 6.2.0 of the `@actions/artifact` library introduces a breaking change in this
function's signature. The previous version expected the third argument to be a
`rootDirectory` string, but the new version expects an optional `options` object.
Passing the `tmpDir` string as the third argument will cause a type mismatch, leading to
a runtime error when the action attempts to upload an artifact.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the actions-deps group with 4 updates: @actions/artifact, @actions/core, @actions/github and @actions/glob.
Updates
@actions/artifactfrom 2.3.2 to 6.2.0Changelog
Sourced from
@actions/artifact's changelog.Commits
Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@actions/artifactsince your current version.Updates
@actions/corefrom 1.11.1 to 3.0.0Changelog
Sourced from
@actions/core's changelog.Commits
Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@actions/coresince your current version.Updates
@actions/githubfrom 6.0.1 to 9.0.0Changelog
Sourced from
@actions/github's changelog.Commits
Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@actions/githubsince your current version.Updates
@actions/globfrom 0.5.0 to 0.6.1Changelog
Sourced from
@actions/glob's changelog.Commits
Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@actions/globsince your current version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions