fix(error-reporting): Silence ResolutionError in Sentry - #1593
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResolutionError, which indicates that a user-provided event ID (or other resource) was not found, was previously being reported to Sentry as an issue.
These errors are user-facing "not found" errors, analogous to
ValidationErrororAuthError– they represent expected user input failures rather than CLI bugs. As such, they should be silenced to reduce noise in Sentry.This change adds
"resolution_error"to theSilenceReasontype and introduces aninstanceof ResolutionErrorcheck inclassifySilenced()to prevent these events from being reported to Sentry, instead emitting acli.error.silencedmetric. This aligns with the existing pattern for other expected user-input failures (CLI-31W).Fixes CLI-31W
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.