fix: three bug fixes — xcode report JSON.parse, upgrade response.json(), seer schema validation

packages/cli/src/commands/react-native/xcode.ts

@@ -240,9 +240,13 @@ function runWrappedBuild(
 
   const status = runScript(script, scriptArgs, env);
 
-  const report = JSON.parse(
-    readFileSync(reportPath, "utf-8")
-  ) as SourceMapReport;
+  let report: SourceMapReport;
+  try {
+    report = JSON.parse(readFileSync(reportPath, "utf-8")) as SourceMapReport;
+  } catch (error) {
+    log.debug("Failed to read sourcemap report file", error);
+    return { status, pair: null };
+  }
   if (!(report.packager_bundle_path && report.packager_sourcemap_path)) {
     return { status, pair: null };
   }

packages/cli/src/lib/api/seer.ts

@@ -6,7 +6,11 @@
  * which returns blocks instead of steps.
  */
 
-import type { AutofixResponse, AutofixState } from "../../types/seer.js";
+import {
+  AutofixResponseSchema,
+  type AutofixResponse,
+  type AutofixState,
+} from "../../types/seer.js";
 
 import { resolveOrgRegion } from "../region.js";
 
@@ -96,6 +100,7 @@ export async function getAutofixState(
     `/organizations/${orgSlug}/issues/${issueId}/autofix/`,
     {
       params: EXPLORER_MODE_PARAMS,
+      schema: AutofixResponseSchema,
     }
   );
 

packages/cli/src/lib/upgrade.ts

@@ -390,7 +390,15 @@ export async function fetchLatestFromGitHub(
     );
   }
 
-  const data = (await response.json()) as { tag_name?: string };
+  let data: { tag_name?: string };
+  try {
+    data = (await response.json()) as { tag_name?: string };
+  } catch {
+    throw new UpgradeError(
+      "network_error",
+      "GitHub returned non-JSON response"
+    );
+  }
 
   if (!data.tag_name) {
     throw new UpgradeError(
@@ -422,7 +430,15 @@ export async function fetchLatestFromNpm(): Promise<string> {
     );
   }
 
-  const data = (await response.json()) as { version?: string };
+  let data: { version?: string };
+  try {
+    data = (await response.json()) as { version?: string };
+  } catch {
+    throw new UpgradeError(
+      "network_error",
+      "npm registry returned non-JSON response"
+    );
+  }
 
   if (!data.version) {
     throw new UpgradeError("network_error", "No version found in npm registry");