Open
Conversation
The function is described in this flow is the `uniqueWords()` wrapper function not `wordsUsed()`
Owner
|
I understand where your confusion came from, but this change is problematic because the whole section of this chapter flows from using I'm going to hold off on this change until revisiting it in second edition. If the name change is important, it should be described in the text. If it's not, then the same name should be used throughout the whole chapter. Thanks for bringing it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function is described in this flow is the
uniqueWords()wrapper function notwordsUsed()I changed the name to be more clear as it confused me on the first pass.