rust-tui: Update Ditto SDK to 4.10.2 and Use Rust 1.81.0#67
Open
kristopherjohnson wants to merge 7 commits intomainfrom
Open
rust-tui: Update Ditto SDK to 4.10.2 and Use Rust 1.81.0#67kristopherjohnson wants to merge 7 commits intomainfrom
kristopherjohnson wants to merge 7 commits intomainfrom
Conversation
kristopherjohnson
changed the title
pvditto
approved these changes
Jun 17, 2025
Contributor
pvditto
left a comment
pvditto
left a comment
There was a problem hiding this comment.
LGTM, some comments below.
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: stable | ||
| toolchain: 1.81.0 |
Contributor
There was a problem hiding this comment.
Is it possible to source this from the rust-toolchain file to avoid a duplicate source of truth?
Member
There was a problem hiding this comment.
Add this step before this "Install Rust" step:
- name: Set RUST_VERSION
run: echo "RUST_VERSION=$(cat rust-toolchain)" >> $GITHUB_ENV
Suggested change
| toolchain: 1.81.0 | |
| toolchain: ${{ env.RUST_VERSION }} |
| @@ -0,0 +1,6 @@ | |||
| fn main() { | |||
| // Workaround for "multiple definition" linker errors on Linux (#SDKS-1088) | |||
Contributor
There was a problem hiding this comment.
Is this fix just needed for our specific CI setup or something that customers should understand how to apply to their own setups? A bit more context could help when someone is reading this code who is not familiar with this issue.
| tracing-subscriber = { version = "0.3.19", features = ["env-filter"] } | ||
| tokio-stream = { version = "0.1.17", features = ["sync"] } | ||
| uuid = "1.13" | ||
|
|
Contributor
There was a problem hiding this comment.
Is this removal of a trailing new line intentional?
Contributor
|
This might need to get closed given we have a PR now for 4.11.1. |
phatblat
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Rust SDK version to 4.10.2, and works around linker errors when building on Ubuntu.
This also updates the GitHub actions to use Rust 1.81.0 in CI, which is the version needed for compatibility with the 4.10.2 SDK.
Closes SDKS-1088