Skip to content

danish i18n messages#11799

Merged
dsuren1 merged 4 commits intogeosolutions-it:masterfrom
nordiq-group:danish_i18n
Mar 2, 2026
Merged

danish i18n messages#11799
dsuren1 merged 4 commits intogeosolutions-it:masterfrom
nordiq-group:danish_i18n

Conversation

@tha-nordiq
Copy link
Copy Markdown
Contributor

@tha-nordiq tha-nordiq commented Dec 11, 2025

Description

We made lots of danish messages. First iteration was made with llm, then various corrections and improvements were made by danish humans.
Its not 100% but pretty close.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:
    i18n

What is the current behavior?
Danish translations were english. So english was shown

What is the new behavior?
Danish translations are shown instead.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@tha-nordiq
Copy link
Copy Markdown
Contributor Author

tha-nordiq commented Dec 17, 2025

@tdipisa Hi Tobia
How can i move forward with this one?
I am not seeing the same error locally, and the error does not seem to be related to my commit, unless i misunderstand something?

@tdipisa tdipisa requested a review from offtherailz January 20, 2026 17:18
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Jan 20, 2026

@tha-nordiq I'm sorry for the late answer. Can you please update your PR to the latest master and resolve conflicts please?

@tdipisa tdipisa added this to the 2026.01.00 milestone Jan 20, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 23, 2026

In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code

@offtherailz offtherailz assigned dsuren1 and unassigned offtherailz Feb 12, 2026
@offtherailz offtherailz requested review from dsuren1 and removed request for offtherailz February 12, 2026 17:35
dsuren1
dsuren1 requested changes Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsuren1 dsuren1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tha-nordiq
Kindly align your branch with latest master and resolve conflicts and please grant me write access to your branch nordiq-group:danish_i18n. I would like to push some updates as part of the review. Since the changes are extensive (missing translation keys), it would be difficult to include them directly in the comments, so I plan to add them as a separate commit instead. Once updated, you could review them, and we can proceed further.

Additionally, you will need to sign the CLA in order to contribute.

@offtherailz
Copy link
Copy Markdown
Member

offtherailz commented Feb 13, 2026 •
edited
Loading

Sorry but recent changes due to CLA and github action checks invalidated your PR 2 times before we had time to merge.
@tha-nordiq of course because you are the danish expert, if you can align the translations files and resolve conflicts, we will take care of taking care of this PR quickly now.

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Feb 13, 2026

@offtherailz thank you. The CLA is signed @tha-nordiq can you just update the branch and solve conflicts? Thank you so much.

@cla-bot cla-bot bot added the CLA Ready label Feb 27, 2026
@dsuren1
Copy link
Copy Markdown
Contributor

dsuren1 commented Feb 27, 2026 •
edited
Loading

@tha-nordiq It seems that the current merge has introduced several unrelated commits and changes. Could you please merge the MapStore2 master (remote) branch into nordiq-group:danish_i18n? The PR should ideally contain only the updates specific to the Danish translations.
Also, could you please grant me access to your local branch? I can then help clean it up and add the missing translations, so you can review the updated keys.

@tha-nordiq
Copy link
Copy Markdown
Contributor Author

tha-nordiq commented Feb 27, 2026 •
edited
Loading

@dsuren1 i dont know what happened now. i tried rebasing and now its a big mess. :(
ive invited you to our fork.
is it easier if i start over and make a new pr?

@dsuren1
Copy link
Copy Markdown
Contributor

dsuren1 commented Feb 27, 2026

@tha-nordiq Thanks for the invite. I’ll take a look and see if we can revert the changes and fix the branch

@dsuren1
Copy link
Copy Markdown
Contributor

dsuren1 commented Feb 27, 2026 •
edited
Loading

@tha-nordiq I have updated the branch and added the missing translations. Please review at your convenience and make any necessary adjustments, committing them to your branch if needed. If all looks good, please let me know so we can merge it. Thank you!

@dsuren1
Copy link
Copy Markdown
Contributor

dsuren1 commented Feb 27, 2026 •
edited
Loading

Warning

test-front-end failure is caused by Coveralls being down for maintenance

tha-nordiq
tha-nordiq commented Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@tha-nordiq tha-nordiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dsuren1 dsuren1 enabled auto-merge (squash) February 27, 2026 12:34
@dsuren1 dsuren1 merged commit 709fb95 into geosolutions-it:master Mar 2, 2026
19 of 22 checks passed
@offtherailz offtherailz mentioned this pull request Mar 2, 2026
Merged
@offtherailz
Copy link
Copy Markdown
Member

offtherailz commented Mar 2, 2026

Successfully created backport PR for 2026.01.xx:

@dsuren1
Copy link
Copy Markdown
Contributor

dsuren1 commented Mar 2, 2026

@ElenaGallo Kindly test the danish translations in DEV when available. Thanks!

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Mar 2, 2026

@ElenaGallo Kindly test the danish translations in DEV when available. Thanks!

@dsuren1 there's nothing to test in DEV for this as danish is not one of the languages regularly maintained across MS releases.

tdipisa pushed a commit that referenced this pull request Mar 2, 2026
@offtherailz @tha-nordiq @dsuren1
danish i18n messages (#11799) (#12031)
a5d294c 
* danish messages

* updated missing translations

* updated translations

---------


(cherry picked from commit 709fb95)

Co-authored-by: Thomas Hallundbæk <72447095+tha-nordiq@users.noreply.github.com>
Co-authored-by: Suren <dsuren1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsuren1 dsuren1 dsuren1 approved these changes

Assignees

@dsuren1 dsuren1

Labels

backport 2026.01.xx CLA Ready External Contribution Translations

Projects

None yet

Milestone

2026.01.00

Development

Successfully merging this pull request may close these issues.

4 participants

@tha-nordiq @tdipisa @offtherailz @dsuren1