Skip to content

implement custom node container for endlevellayer to resolve label overlap issues across the geode index#137

Merged
Cvolton merged 8 commits intogeode-sdk:mainfrom
RayDeeUx:next-key-when
Feb 14, 2026
Merged

implement custom node container for endlevellayer to resolve label overlap issues across the geode index#137
Cvolton merged 8 commits intogeode-sdk:mainfrom
RayDeeUx:next-key-when

Conversation

@RayDeeUx
Copy link
Contributor

@RayDeeUx RayDeeUx commented Jan 6, 2026

original code + approach by @Alphalaneous, based on code from https://github.com/Alphalaneous/NextKeyWhen.

this PR has been made to resolve overlap issues such as the screenshot below by @undefined06855, exacerbated by certain options from @absoIute's Mega Hack v9.x mod menu:

this change would affect at minimum the following mods (listed in alphabetical order):

all four mod developers have been made aware of this proposal and agree to it.

as this pull request removes nodes from their intended node parents, it's best if the changes made from this PR were introduced to the geode index after Geode v5.x releases.

@RayDeeUx
Copy link
Contributor Author

RayDeeUx commented Jan 6, 2026

i did move the complete-message node to y pos 109 for all level types because:
(a) no one wanted y pos 147 for platformer levels let's be fr rn
(b) summary-container's nodes would be more important that avoiding the overlap is easier as a blanket treatment

complete-message is for editor levels, so this change won't affect the ypos of level completion messages for online levels

@RayDeeUx
Copy link
Contributor Author

RayDeeUx commented Jan 6, 2026

no one wanted [complete-message] y pos 147 for platformer levels let's be fr rn

for evidence of this: the end-text node is always at y position 95 regardless of level type/length, even though vanilla GD only shows one piece of information on EndLevelLayer

@Alphalaneous
Copy link
Contributor

lgtm

@Cvolton
Copy link
Member

Cvolton commented Feb 14, 2026

alpha says its good so i hope its good

@Cvolton Cvolton merged commit 0163c1e into geode-sdk:main Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants