Remove cookie domain as it could be munged from scenario url#1258
Open
digitaldonkey wants to merge 2 commits intogarris:masterfrom
Open
Remove cookie domain as it could be munged from scenario url#1258digitaldonkey wants to merge 2 commits intogarris:masterfrom
digitaldonkey wants to merge 2 commits intogarris:masterfrom
Conversation
garris
requested changes
Mar 29, 2021
Owner
garris
left a comment
garris
left a comment
There was a problem hiding this comment.
Just one thought re: domain property in the cookies.json file.
| @@ -1,6 +1,5 @@ | |||
| [ | |||
| { | |||
| "domain": ".www.yourdomain.com", | |||
Owner
There was a problem hiding this comment.
Only problem I have here is that this property will be there when using popular plugins to create this JSON file. So, I prefer to leave this as I imagine many users will include this.
| cookie.url = cookie.domain; | ||
| } else { | ||
| cookie.url = 'https://' + cookie.domain; | ||
| cookie.url = `${url.protocol}//${url.hostname}`; |
Owner
There was a problem hiding this comment.
I prefer this way more to what is currently here. I am a little conflicted about using the "magic" hostname since this could differ from the one exported in the cookie-- but I think this is your whole point. So, I am supportive of this because it will probably work more often than not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to make our our pipeline multi domain compatible we stumbled into the cookie domain setting in provided by default in cookies.json. With a little fix in loadCookies.json you can avoid specifying domain per cookie.
I think it might be a good default setting.