Conversation
add ability to add multiple cookies in a single step, from a list of cookie strings
SchlenkR
left a comment
SchlenkR
left a comment
There was a problem hiding this comment.
- In general, the functions in
DslCEare basically mirrored from the functions inDsl. The implementation is inDslmodule and theDslCEfunctions are forwarding calls to their correspondingDslfunction. - What is the benefit of a single
Cookiesoperation passing a seq of cookies in comparison to use multiple single-Cookiestatements? I don't see a big advantage here - maybe a little less writing - but some downsides:- There are 3 overloads for single cookies that clarify the available parameters and their meaning. Having just one
Cookiesoperation that gets a sequence of strings will hide that. - Writing multiple single-cookie statements are close to how a raw HTTP request looks like.
- There are 3 overloads for single cookies that clarify the available parameters and their meaning. Having just one
|
Related to #2 |
|
yes i agree, maybe is not needed but indeed was linked to trying to read Accept-Cookies from response headers and place them all in the new request in 1 go |
The response header I know is If so, it would propable be useful to change the signature to accepting either
Do you have a working example (maybe with an available online test service)? |
|
🤖 This is an automated response from Repo Assist. Hi Just checking in — are you still interested in pursuing this? If you'd like to continue, providing a working example with a publicly available test service (as suggested) would be a great next step. Alternatively, if you'd like to hand off the work to someone else or close the PR, that's totally fine too! No pressure either way — just wanted to make sure this doesn't get lost. 😊
|
2 participants
add ability to add multiple cookies in a single step, from a list of cookie strings