Merged
Conversation
bvenn
reviewed
Aug 12, 2025
bvenn
approved these changes
Aug 12, 2025
Member
There was a problem hiding this comment.
Sorry it took me a while to review this PR. The proposed changes are excellent and will improve the quality and conciseness of this project. Many thanks to @muehlhaus, @kMutagene and @ZimmerD! ❤️
Here are some comments (that do not stop me from approving this PR):
- why is the GeneralisedLinearModel fs and docu removed?
- if unused as @kMutagene suggested, could you remove the lapack dlls?
- Should the outstanding PRs #348 and #350 be merged into
datasciencebefore merging into dev? - The release notes should be updated with the introduced changes. I'm happy to assist or create a first draft, but I assume you could summarise the changes more effectively. Please let me know which you would prefer.
Member
@bvenn this is intended as that module is currently being moved into a separate repo according to @LibraChris. I removed the native binaries, and @LibraChris will take a look at the 2 open PRs, but i think we should target a release very soon. |
- 'Fixed' case was incorrectly using Random logic - 'Random' case was using Mixed logic - 'Mixed' case was using Fixed logic Corrected F-test denominator assignments for each TwoWayAnovaModel type.
Fix incorrect F-test denominator assignments in TwoWayAnovaModel
Marked _betaLn, _beta, betaLn, and beta functions as 'inline' to enable generic numeric support.
Update test statistics to support generic type 'T data
Member
|
The referenced PRs are closed, native binaries are removed, and i added some release notes. I'll merge and release this as 1.0.0-preview.1 @bvenn 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please reference the issue(s) this PR is related to
Closes #351
Please list the changes introduced in this PR
FsMathas the new lightweight, array-centric math backend.FsMathprimitives for zero-friction integration.FsMath’s optimized routines.Description
This PR introduces a separation of concerns between statistical algorithms and low-level numerical primitives.
Vector and matrix types have been moved to the new
FsMathlibrary under FsLab.org, which is optimized for performance and designed for seamless interoperability.This change keeps FSharp.Stats focused on statistical functionality while making it easier to maintain and integrate into other F# workflows that rely on common libraries.
Migration note
If your project uses
VectororMatrixtypes from FSharp.Stats, you will now need to referenceFsMathand update youropenstatements accordingly:All existing APIs are preserved with minimal changes, so most code will require slight modifications from
vectortoVector<float>explicitly, along with namespace adjustments.Previously, arrays needed to be explicitly converted to vectors - now,
ArrayandVectorcan be used synonymously, removing the need for manual conversions in most cases.[Required] please make sure you checked that
[Optional]