You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds xen_privcmd.unrestricted to the boot options for the workstation kernel, to work around fixes for XSA-482 that are not security-relevant for Qubes.
Test plan
Visual review confirming the .cfg file is correctly formatted is sufficient
extra points - run make securedrop-workstation-6.6 and verify the additional grub.cfg file is present in the securedrop-workstation-grsec package
super extra points - as above but also install the kernel in an SDW template and verify that it boots.
I may be late on this one, but I'll share my findings anyways.
Adds xen_privcmd.unrestricted to the boot options for the workstation kernel, to work around fixes for XSA-482 that are not security-relevant for Qubes.
Note this does weaken in-VM isolation a bit (or rather: revert recent improvement), especially against processes with access to /dev/xen/privcmd. But it does not affect cross-VM isolation.
Since it's creation the client's apparmor includes binary and therefore think that it deserves some consideration.
Since it was a relatively recent feature, I don't think this should block a kernel release (whole delay also has security implications), but I wanted to share my findings for a potential future evaluation in an topic-adjacent conversation we have planned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
xen_privcmd.unrestrictedto the boot options for the workstation kernel, to work around fixes for XSA-482 that are not security-relevant for Qubes.Test plan
make securedrop-workstation-6.6and verify the additional grub.cfg file is present in the securedrop-workstation-grsec package