Skip to content

ofed: Fix build with -Werror -Wdate-time#715

Closed
igalic wants to merge 1 commit intofreebsd:mainfrom
igalic:fix/opensm-Wdate-time
Closed

ofed: Fix build with -Werror -Wdate-time#715
igalic wants to merge 1 commit intofreebsd:mainfrom
igalic:fix/opensm-Wdate-time

Conversation

@igalic
Copy link
Copy Markdown
Contributor

@igalic igalic commented Apr 12, 2023

FreeBSD 14 adds -Werror -Wdate-time to its build which trips up on opensm's build. Remove it from the code, as it doesn't really add much.

This fixes builds WITH_OFED_EXTRA.

PR: 270776
Upstream Pull-Request: linux-rdma/opensm#33

@hselasky
Copy link
Copy Markdown
Contributor

What is the e-mail address (previously submitted by line) you would like to appear in the commit message?

Comment thread contrib/ofed/opensm/opensm/osm_console.c Outdated
Comment thread contrib/ofed/opensm/opensm/osm_console.c Outdated
@emaste
Copy link
Copy Markdown
Member

emaste commented Apr 12, 2023

What is the e-mail address (previously submitted by line) you would like to appear in the commit message?

It should just carry though from the pull request, see e.g. 0b0ae2e

commit 0b0ae2e4cd22c21f3c1971b1cfff9893b30d9f6f
Author:     Mina Galić <freebsd@igalic.co>
AuthorDate: Tue Mar 14 21:04:40 2023 -0600
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: Tue Mar 14 21:05:33 2023 -0600
...
    Pull Request: https://github.com/freebsd/freebsd-src/pull/663

@bsdimp
Copy link
Copy Markdown
Member

bsdimp commented Apr 12, 2023

Yea, git cherry-pick just does the right thing, except to add Pull Request: line (which you need to do manually)

@hselasky
Copy link
Copy Markdown
Contributor

Yea, git cherry-pick just does the right thing, except to add Pull Request: line (which you need to do manually)

Thank you. It is not so often I pull from github into the source tree.

@igalic igalic force-pushed the fix/opensm-Wdate-time branch from e36a3cc to b2c366e Compare April 12, 2023 19:00
@igalic
Copy link
Copy Markdown
Contributor Author

igalic commented Apr 12, 2023

removed the " build"

FreeBSD 14 adds -Werror -Wdate-time to its build which trips up on
opensm's build. Remove it from the code, as it doesn't really add much.

This fixes builds WITH_OFED_EXTRA.

PR: 270776
Upstream Pull-Request: linux-rdma/opensm#33
@igalic igalic force-pushed the fix/opensm-Wdate-time branch from b2c366e to 711ac6d Compare April 27, 2023 19:58
Copy link
Copy Markdown
Contributor

@hselasky hselasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is pushing this?

freebsd-git pushed a commit that referenced this pull request May 1, 2023
This fixes builds WITH_OFED_EXTRA=YES .

PR:		270776
Pull Request:	#715
MFC after:	1 week
Sponsored by:	NVIDIA Networking
@hselasky
Copy link
Copy Markdown
Contributor

hselasky commented May 1, 2023

This pull request can be closed now!

@igalic
Copy link
Copy Markdown
Contributor Author

igalic commented May 1, 2023

merged in d502d3f

@igalic igalic closed this May 1, 2023
@igalic igalic deleted the fix/opensm-Wdate-time branch May 1, 2023 12:03
@emaste emaste added the merged Closed commit that's been merged label Jun 12, 2023
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Jul 20, 2023
This fixes builds WITH_OFED_EXTRA=YES .

PR:		270776
Pull Request:	freebsd/freebsd-src#715
MFC after:	1 week
Sponsored by:	NVIDIA Networking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged Closed commit that's been merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants