ParseableRoute - abstraction for routes and support for Rails 3.1#38
Open
robbjl wants to merge 3 commits intofredwu:masterfrom
Open
ParseableRoute - abstraction for routes and support for Rails 3.1#38robbjl wants to merge 3 commits intofredwu:masterfrom
robbjl wants to merge 3 commits intofredwu:masterfrom
Conversation
… classes This class will be used to create a consistent API for api_taster/route to use when parsing routes, in order to better support different versions of Rails (notably 3.1 which uses ActionDispatch::Routing::Route instead of Journey::Route)
Owner
|
Nice! Could you please update the code to use hash rockets so that it passes Travis's ruby 1.8.7 build? Thanks! :) |
Author
|
Sure, sorry about that. Been using 1.9.3 exclusively for so long I forgot about them! |
Owner
|
Hi @robbjl thank you so much for the PR! Sorry I haven't had a chance to review this for such a long time. Is your app still on rails 3.1? I am undecided on this PR as rails 4.0 is now released, and I personally don't have any rails 3.1 apps around. Hence I'm probably in favour of dropping support for 3.1. Having said that, if you could rebase this PR I will merge it in! :) |
Collaborator
|
Hi @robbjl is this patch still need it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I experienced the same problem as in Issue 26, where normalise_routes! was throwing an exception parsing my routes - "undefined method `source' for "GET":String".
My app is running Rails 3.1.10, and I found that the issue stemmed from the difference between the ActionDispatch::Routing::Route objects in Rails 3.1 and the newer Journey::Route objects in Rails 3.2.
Rather than add a bunch of conditional logic inside Route.normalise_routes! and Route.normalise_route, I wrapped the Rails routes in an abstraction which handles the differences in the interfaces between an ActionDispatch::Routing::Route and a Journey::Route, such as #verb being a String in the former and a Regexp in the latter. For me, this resolved the error from Issue 26 and got my routes all parsed correctly.