Fix the studio not loading, "open in studio" and re-rendering - #618
Merged
Merged
Conversation
…are the spinner outside of the crashing tree...
…udio is unmounted
|
Member
Matthbo
approved these changes
Sep 29, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




I fixed the projectlanding page flickering (re-rendering) by only subscribing to addToast and adding a useMemo in the useToasts store. I find these things stay very tricky so I left some comments to clarify why I did it.
The file structure created issues because it tried to load without any data:
I hate the non-null operator being used like this.
Also moved spinner so it is rendered outside of the tree.
When using the "open in studio" button, the studio would open the previous content in a new tab. I fixed it by adding a loadedTabId which makes checking in the canvas-flow.tsx easier.