Skip to content

Fix the studio not loading, "open in studio" and re-rendering - #618

Merged
philipsens merged 4 commits into
masterfrom
fix-flow3
Sep 29, 2026
Merged

philipsens merged 4 commits into
masterfrom
fix-flow3

Conversation

@philipsens

Copy link
Copy Markdown
Member

I fixed the projectlanding page flickering (re-rendering) by only subscribing to addToast and adding a useMemo in the useToasts store. I find these things stay very tricky so I left some comments to clarify why I did it.

The file structure created issues because it tried to load without any data:

dataProvider={dataProvider!}

I hate the non-null operator being used like this.
Also moved spinner so it is rendered outside of the tree.

When using the "open in studio" button, the studio would open the previous content in a new tab. I fixed it by adding a loadedTabId which makes checking in the canvas-flow.tsx easier.

@philipsens
philipsens requested a review from Matthbo September 28, 2026 15:37
@sonarqubecloud

Copy link
Copy Markdown

@Matthbo

Matthbo commented Sep 28, 2026

Copy link
Copy Markdown
Member

Both the flow store and canvas will be quite different with the current issue I'm working on but we'll see how it'll turn out.
If this fixes the current deployment then this is a win for now.

nodding gif

@philipsens
philipsens merged commit 18af376 into master Sep 29, 2026
5 checks passed
@philipsens
philipsens deleted the fix-flow3 branch September 29, 2026 08:10
@philipsens

Copy link
Copy Markdown
Member Author

Both the flow store and canvas will be quite different with the current issue I'm working on but we'll see how it'll turn out. If this fixes the current deployment then this is a win for now.

nodding gif nodding gif

Yea I was thinking the same. Maybe you could just overwrite it and I could look if its still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants