Skip to content

fix(wasm): remove hardcoded Stack Witness text fixture#377

Merged
flyingrobots merged 2 commits into
mainfrom
stack/remove-wasm-stack-witness-fixture
May 24, 2026
Merged

fix(wasm): remove hardcoded Stack Witness text fixture#377
flyingrobots merged 2 commits into
mainfrom
stack/remove-wasm-stack-witness-fixture

Conversation

@flyingrobots
Copy link
Copy Markdown
Owner

Summary

  • remove the legacy Stack Witness createBuffer / replaceRange / textWindow shortcut from warp-wasm
  • make QueryView fail closed with UNSUPPORTED_QUERY unless an installed contract query observer exists
  • rename warp-core structured binding test fixtures away from rope/text nouns so core executable examples remain generic
  • mark the old Stack Witness design packet as historical

Validation

  • cargo test -p warp-core dynamic_binding --lib
  • cargo test -p warp-wasm --features engine
  • pre-push exact slices: cargo test -p warp-core --lib dynamic_binding::tests; cargo test -p warp-wasm --features engine --lib warp_kernel::tests
  • git diff --check

Companion

This pairs with the jedit PR update that keeps TextBufferOptic and text/rope semantics in jedit-owned ports, adapters, and contracts.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 23, 2026

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 10 minutes and 13 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: bc47a9d8-0418-49eb-a8f3-16ad255d3333

📥 Commits

Reviewing files that changed from the base of the PR and between d0b9ad2 and 282f817.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • crates/warp-core/src/dynamic_binding.rs
  • crates/warp-wasm/src/warp_kernel.rs
  • crates/warp-wasm/test/fixtures/stack-witness-0001-vectors.json
  • docs/design/stack-witness-0001-jedit-file-history.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stack/remove-wasm-stack-witness-fixture

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@flyingrobots
Copy link
Copy Markdown
Owner Author

Self-audit found one review item before patching. Cc @codex for spot check.

Severity File Lines Issue Recommended mitigation
P4 crates/warp-wasm/src/warp_kernel.rs 1729 The new QueryView unsupported regression asserts a human error-message substring with a hardcoded decimal query id. That makes the witness brittle and couples the test to prose formatting rather than typed behavior. Remove the message-substring assertion or replace it with structured error evidence if the ABI exposes it. Keep the regression focused on error_codes::UNSUPPORTED_QUERY.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25c5a15109

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/warp-wasm/src/warp_kernel.rs Outdated
@flyingrobots
Copy link
Copy Markdown
Owner Author

Activity Summary for PR #377

Issue Severity Source File Addressed by Regression coverage Outcome
Brittle unsupported QueryView regression asserted human message text and a hardcoded decimal query id. P4 Self-audit crates/warp-wasm/src/warp_kernel.rs 282f817 if rg -n 'query id 1398214657' crates/warp-wasm/src/warp_kernel.rs; then exit 1; fi; cargo test -p warp-wasm --features engine queryview_without; pre-push cargo test -p warp-wasm --features engine --lib warp_kernel::tests Resolved. The test now asserts typed ABI error code behavior only.

Local verification:

  • cargo fmt --all --check
  • git diff --check
  • cargo test -p warp-wasm --features engine queryview_without
  • cargo test -p warp-core --lib dynamic_binding::tests
  • pre-push cargo test -p warp-wasm --features engine --lib warp_kernel::tests (38 tests)

Review thread state: 0 unresolved review threads.

@flyingrobots flyingrobots merged commit 1d36ea7 into main May 24, 2026
36 checks passed
@flyingrobots flyingrobots deleted the stack/remove-wasm-stack-witness-fixture branch May 24, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant