fix(wasm): remove hardcoded Stack Witness text fixture#377
Conversation
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 10 minutes and 13 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Self-audit found one review item before patching. Cc @codex for spot check.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25c5a15109
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Activity Summary for PR #377
Local verification:
Review thread state: 0 unresolved review threads. |
Summary
createBuffer/replaceRange/textWindowshortcut fromwarp-wasmUNSUPPORTED_QUERYunless an installed contract query observer existswarp-corestructured binding test fixtures away from rope/text nouns so core executable examples remain genericValidation
cargo test -p warp-core dynamic_binding --libcargo test -p warp-wasm --features enginecargo test -p warp-core --lib dynamic_binding::tests;cargo test -p warp-wasm --features engine --lib warp_kernel::testsgit diff --checkCompanion
This pairs with the jedit PR update that keeps
TextBufferOpticand text/rope semantics in jedit-owned ports, adapters, and contracts.