adds SSH signature validation for git commits#1141
Open
bb-Ricardo wants to merge 13 commits intofluxcd:mainfrom
Open
adds SSH signature validation for git commits#1141bb-Ricardo wants to merge 13 commits intofluxcd:mainfrom
bb-Ricardo wants to merge 13 commits intofluxcd:mainfrom
Conversation
bb-Ricardo
force-pushed
the
rb-feature/adds-ssh-signature-validation
branch
2 times, most recently
from
96523af to
1561774
Compare
Member
|
@bb-Ricardo please run |
bb-Ricardo
force-pushed
the
rb-feature/adds-ssh-signature-validation
branch
from
eedb46c to
048e862
Compare
2 tasks
bb-Ricardo
force-pushed
the
rb-feature/adds-ssh-signature-validation
branch
from
e247a34 to
5e6ab4d
Compare
Author
|
Hi, was just wondering if this PR is sufficient or if anything else is needed? |
stefanprodan
added
enhancement
Member
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
Tests are failing with open signatures/... no such file or directory please run make test-git before pushing commits.
Author
|
sorry for that, now the tests passed locally. |
hiddeco
reviewed
Mar 10, 2026
bb-Ricardo
force-pushed
the
rb-feature/adds-ssh-signature-validation
branch
from
83338dc to
51ceefd
Compare
Author
|
@hiddeco - would you mind to have a look at this PR again? Thank you. |
pjbgf
requested changes
Mar 19, 2026
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
@bb-Ricardo thanks for working on this. Overall LGTM, however I'd remove any references to DSA as per thread below.
Member
|
@bb-Ricardo please use rebase not merge. Undo the last merge, and properly rebase your fork, GH has a button for this if you go to your forked repo. |
bb-Ricardo
force-pushed
the
rb-feature/adds-ssh-signature-validation
branch
from
b6f0ece to
bd9abd8
Compare
Author
Yes, sorry. I used the seemingly convenient button GitHub offered in this PR. I removed all occurrences of GPG DSA keys in the tests and test fixtures. |
bb-Ricardo
force-pushed
the
rb-feature/adds-ssh-signature-validation
branch
from
bd9abd8 to
fa037d1
Compare
bb-Ricardo
force-pushed
the
rb-feature/adds-ssh-signature-validation
branch
from
fa037d1 to
0811c24
Compare
Author
|
Hi, was wondering if anything else is needed. Thank you |
bb-Ricardo
force-pushed
the
rb-feature/adds-ssh-signature-validation
branch
from
0811c24 to
af44b2c
Compare
- adds new package git/signatures - adds validation of SSH signed commits to ssh_signature.go - moves GPG signature validation to gpg_signature.go - adds text fixtures for all SSH and GPG key types including commits and signatures - adds tests for all key/signature combinations - adds wrapper for "Verify(keyRings ...string)" function Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
…tureType' Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com> Signed-off-by: Ricardo <ricardo@bitchbrothers.com> Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
Signed-off-by: Ricardo Bartels <ricardo.bartels@telekom.de>
bb-Ricardo
force-pushed
the
rb-feature/adds-ssh-signature-validation
branch
from
af44b2c to
074c9de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support of SSH signature validation.
resolves: fluxcd/flux2#4145