Skip to content

[material_ui] Standardize M3 and M3E token template base class names - #12675

Open
elliette wants to merge 1 commit into
flutter:mainfrom
elliette:port-pr-12209
Open

[material_ui] Standardize M3 and M3E token template base class names#12675
elliette wants to merge 1 commit into
flutter:mainfrom
elliette:port-pr-12209

Conversation

@elliette

Copy link
Copy Markdown
Member

Work towards flutter/flutter#191088

Ports over #12209 which landed on the m3e_migration feature branch.

Original PR description

As title. Related to flutter/flutter#187899

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

…lutter#12209)

As title. Related to flutter/flutter#187899


## Pre-Review Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran [the
auto-formatter].
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I followed [the version and CHANGELOG instructions], using
[semantic versioning] and the [repository CHANGELOG style], or I have
commented below to indicate which documented exception this PR falls
under[^1].
- [x] I updated/added any relevant documentation (doc comments with
`///`).
- [x] I added new tests to check the change I am making, or I have
commented below to indicate which [test exemption] this PR falls
under[^1].
- [ ] All existing and new tests are passing.
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 28, 2026
@elliette
elliette requested a review from QuncCccccc August 28, 2026 16:56

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the template classes M3TokenTemplate and M3ETokenTemplate to TokenTemplateM3 and TokenTemplateM3E, and updates the generated file naming convention from *_m3_defaults.g.dart to *_defaults_m3.g.dart. The corresponding tests and test fixtures have been updated to reflect these changes. Feedback is provided regarding a missing blank line between test blocks in the test suite to maintain consistency and readability.

Comment on lines 148 to 149
});

test('will run dart format over the generated file', () {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and consistency with the rest of the test suite, please maintain a blank line between the test blocks.

Suggested change
});
test('will run dart format over the generated file', () {
});
test('will run dart format over the generated file', () {

@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants