Skip to content

[google_maps_flutter] Convert marker controllers to Swift - #12662

Open
stuartmorgan-g wants to merge 9 commits into
flutter:mainfrom
stuartmorgan-g:maps-swift-markers
Open

[google_maps_flutter] Convert marker controllers to Swift#12662
stuartmorgan-g wants to merge 9 commits into
flutter:mainfrom
stuartmorgan-g:maps-swift-markers

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

This converts MarkerController and ClusterManagersController to Swift in the _sdk* packages.

The remaining Obj-C code will be migrated in a series of follow-up PRs to keep the scope of each PR reasonable for review.

The conversion process was:

  • Initial conversion via Gemini, with explicit instruction to keep the structure the same.
  • Side-by-side manual review of the old and new versions of the files.
  • Manual fixes and improvements.

Part of flutter/flutter#119108

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request converts the marker and cluster manager controllers from Objective-C to Swift across the google_maps_flutter_ios_sdk10, google_maps_flutter_ios_sdk9, and shared iOS codebases. The feedback recommends aligning the opening braces of function declarations to the same line in ConversionUtils.swift to adhere to Swift style guidelines. Additionally, it suggests simplifying the extraction of marker identifiers in pigeonCluster by replacing the filter and force-cast chain with a single, safer compactMap operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant