[google_maps_flutter] Convert marker controllers to Swift - #12662
Open
stuartmorgan-g wants to merge 9 commits into
Open
[google_maps_flutter] Convert marker controllers to Swift#12662stuartmorgan-g wants to merge 9 commits into
stuartmorgan-g wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request converts the marker and cluster manager controllers from Objective-C to Swift across the google_maps_flutter_ios_sdk10, google_maps_flutter_ios_sdk9, and shared iOS codebases. The feedback recommends aligning the opening braces of function declarations to the same line in ConversionUtils.swift to adhere to Swift style guidelines. Additionally, it suggests simplifying the extraction of marker identifiers in pigeonCluster by replacing the filter and force-cast chain with a single, safer compactMap operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts MarkerController and ClusterManagersController to Swift in the
_sdk*packages.The remaining Obj-C code will be migrated in a series of follow-up PRs to keep the scope of each PR reasonable for review.
The conversion process was:
Part of flutter/flutter#119108
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2