[google_sign_in] PR 1/4 google_sign_in_ios SPM packaging - #12654
[google_sign_in] PR 1/4 google_sign_in_ios SPM packaging#12654victogomez-cs wants to merge 3 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the google_sign_in_ios package to version 6.3.2, introducing a Swift Package Manager target for the Swift implementation. It splits the codebase into separate google_sign_in_ios (Swift) and google_sign_in_ios_objc (Objective-C) targets in Package.swift, while combining them in the Podspec for CocoaPods compatibility. Additionally, it updates Pigeon generation paths to output Objective-C files to the new google_sign_in_ios_objc directory and adds conditional imports in tests and a new placeholder file. There are no review comments, so no further feedback is provided.
c2332fb to
2cf54ae
Compare
The Obj-C target is still pulled in as a dependency of google_sign_in_ios, matching video_player_avfoundation and in_app_purchase_storekit.
2cf54ae to
b306c56
Compare
Creates a Swift Package Manager target so later PRs can add Swift sources without mixing them into the Obj-C target. CocoaPods still builds both as one pod.
This is packaging-only: Obj-C sources move to
google_sign_in_ios_objc, and a placeholder Swift target re-exports that module. Plugin behavior is unchanged.Matches the Obj-C / Swift SPM split already used by
video_player_avfoundationandin_app_purchase_storekit:Package.swift:google_sign_in_iosdepends ongoogle_sign_in_ios_objc; only the Swift product is exportedsource_filesglob plus Swift stdlib xcconfiginclude/google_sign_in_iosso existing#import <google_sign_in_ios/...>keeps working#if canImport(google_sign_in_ios_objc)for the Obj-C moduleBumps
google_sign_in_iosto 6.3.2.PR 1/4 of the Obj-C → Swift migration. Follows #12484 (coverage backfill). Part of flutter/flutter#119103
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2