[material_ui] Add helper methods in gen_defaults template #12121
Merged
QuncCccccc merged 2 commits intoJul 8, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Material 3 component defaults generator by renaming the generated class suffixes and adding helper methods to generate Dart expressions for token numbers, colors, and shapes. It also updates the corresponding tests and test fixtures to cover these new capabilities. Review feedback suggests optimizing the colorWithOpacity helper to avoid redundant calls when opacity is 1.0, and correcting a minor formatting issue by adding a space after the comma in the generated BorderRadius.vertical expression and its corresponding test.
11 tasks
2978a75 to
e037015
Compare
10 tasks
elliette
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to flutter/flutter#184950
This PR is to add some helper methods to handle color, and shape tokens. Also I updated the generated default class name from
_M3xxxto_xxxM3to keep the name consistent with the original M2 and M3 defaults.Pre-Review Checklist
[shared_preferences]///).