[material_ui, cupertino_ui] Migrate dartpad TODOs to <callout-box>#12120
Open
dkwingsmt wants to merge 8 commits into
Open
[material_ui, cupertino_ui] Migrate dartpad TODOs to <callout-box>#12120dkwingsmt wants to merge 8 commits into
<callout-box>#12120dkwingsmt wants to merge 8 commits into
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request wraps example documentation blocks in tags across multiple Cupertino and Material UI components, and disables the unintended_html_in_doc_comment linter rule. Feedback on the changes highlights that placing regular // TODO comments inside contiguous /// doc comment blocks terminates the block, causing dartdoc to ignore the preceding documentation. The reviewer suggests moving these // TODO comments outside of the doc comment blocks to ensure correct API documentation generation.
Contributor
Author
|
FYI this PR is now ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Dartdoc 9.0.7 added support for
<callout-box>(what we used to call the blue container).What's changed
This PR migrates all should-be Dartpad instances in API docs to
<callout-box>. This is what it looks like:This PR also disables
unintended_html_in_doc_commentbecause<callout-box>is not recognized by the linter for now. An issue has been filed: dart-lang/sdk#63777Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2