[quick_actions] Convert example to Swift#10970
[quick_actions] Convert example to Swift#10970auto-submit[bot] merged 8 commits intoflutter:mainfrom
Conversation
stuartmorgan-g
added
the
override: no versioning needed
stuartmorgan-g
requested review from
LongCatIsLooong and
LouiseHsu
as code owners
stuartmorgan-g
added
the
override: no changelog needed
|
Changelog/version override: only affects example app config that's not relevant to clients. |
| BlueprintIdentifier = "686BE82C25E58CCF00862533" | ||
| BuildableName = "RunnerUITests.xctest" | ||
| BlueprintName = "RunnerUITests" | ||
| BlueprintIdentifier = "331C8080294A63A400263BE5" |
There was a problem hiding this comment.
Because I remade things, there is a fair amount of thrashing in the diffs around Xcode-generated identifiers, order of entries in the project file, etc. I didn't try to smooth those out since they don't really matter.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the iOS example application for the quick_actions package from Objective-C to Swift. The ios directory has been regenerated using a modern Swift-based Flutter project template. Changes include updating the Xcode project file (.pbxproj), configuration files (.xcconfig, .plist), and build schemes (.xcscheme) to reflect the new project structure and settings. The Objective-C AppDelegate has been replaced with a Swift equivalent. Existing native test files have been re-integrated into the new project. This is a valuable maintenance update that modernizes the example.
packages/quick_actions/quick_actions_ios/example/ios/Runner.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
packages/quick_actions/quick_actions_ios/example/ios/Runner.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
packages/quick_actions/quick_actions_ios/example/ios/Runner.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Same here; we could keep the old icons, but we already have copies of the new icons in the repo so in terms of repo size this is basically a no-op, and helps us standardize on current state.
| didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? | ||
| ) -> Bool { | ||
| GeneratedPluginRegistrant.register(with: self) | ||
| return super.application(application, didFinishLaunchingWithOptions: launchOptions) |
There was a problem hiding this comment.
The objc implementation returns NO here. Is the change intended?
There was a problem hiding this comment.
No, I missed that it wasn't quite a stock AppDelegate.m. Great catch! I tracked this back to flutter/plugins#3811
I'll change it, and add a comment so that it's more obvious to the next person looking at this code :)
stuartmorgan-g
added
the
autosubmit
flutter/packages@7805d3e...3d5eaa5 2026-02-08 engine-flutter-autoroll@skia.org Roll Flutter from f916dd6 to e8f9dc5 (34 revisions) (flutter/packages#10979) 2026-02-07 stuartmorgan@google.com [quick_actions] Convert example to Swift (flutter/packages#10970) 2026-02-07 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift migration - part 1 (flutter/packages#10939) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#182083) flutter/packages@7805d3e...3d5eaa5 2026-02-08 engine-flutter-autoroll@skia.org Roll Flutter from f916dd6 to e8f9dc5 (34 revisions) (flutter/packages#10979) 2026-02-07 stuartmorgan@google.com [quick_actions] Convert example to Swift (flutter/packages#10970) 2026-02-07 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift migration - part 1 (flutter/packages#10939) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#182083) flutter/packages@7805d3e...3d5eaa5 2026-02-08 engine-flutter-autoroll@skia.org Roll Flutter from f916dd6 to e8f9dc5 (34 revisions) (flutter/packages#10979) 2026-02-07 stuartmorgan@google.com [quick_actions] Convert example to Swift (flutter/packages#10970) 2026-02-07 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift migration - part 1 (flutter/packages#10939) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Replaces the Obj-C example app with Swift. Rather than attempt to modify the example in place, I started clean from the Swift template:
flutter create --platforms=ios .using currentstable(3.38.9).Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3