Release automation.#917
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request restructures the project's contribution documentation by moving detailed guidelines from the root CONTRIBUTING.md to a new docs/contributing directory, which now includes dedicated guides for publishing and pull requests. It also updates package versions and adds publishing restrictions to internal tools. The review feedback identified several opportunities to improve the clarity, grammar, and link stability of the newly added documentation files.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Avoids pub publish --dry-run flagging gitignored-but-checked-in files inside the a2ui submodule. The genui package's published sources don't depend on submodule contents.
With checkout_submodules: false in the publish workflow, the submodule contents aren't present at validation time, so the .pubignore rules aren't needed and were themselves matching the bare gitlinks, triggering 'tracked but ignored' warnings.
Relocates the a2ui and JSON-Schema-Test-Suite git submodules from inside packages/ to a top-level submodules/ directory so they are not part of any pub package's source tree. This unblocks pub publish --dry-run for genui and json_schema_builder, which was flagging the submodule gitlinks as 'tracked but ignored'. - packages/genui/submodules/a2ui -> submodules/a2ui - packages/json_schema_builder/submodules/JSON-Schema-Test-Suite -> submodules/JSON-Schema-Test-Suite Updates: - .gitmodules paths - analysis_options.yaml exclude pattern - json_schema_builder test fixture paths (now ../../submodules/...) - .agent/skills/genui-helper/SKILL.md references
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request restructures the repository's documentation and submodule paths, moving submodules to a top-level directory and updating references across SKILL.md, .gitmodules, and analysis_options.yaml. It introduces new documentation files for publishing and pull request guidelines while streamlining CONTRIBUTING.md. Feedback focused on improving the new documentation by replacing a specific CI run link with a general workflow link, correcting minor grammatical errors, and removing trailing whitespace.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
Contributes to google/A2UI#1383.
Prerequisite: #926