dt: allow DEVTOOLS_TOOL_FLUTTER_FROM_PATH to be used in CI scripts - #9999
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
| @override | ||
| Future<void> runCommand(ArgResults topLevelResults) { | ||
| final flutterFromPathEnv = | ||
| Platform.environment[_flutterFromPathEnvVar]?.isNotEmpty == true; |
Member
There was a problem hiding this comment.
should we check that this flag == true? or is checking its presence sufficient? What if someone sets it to false thinking that will disable this behavior?
Contributor
Author
There was a problem hiding this comment.
We could, I agree it would be surprising if someone set it to false, and we acted like it was true. But this is the existing behavior in dt:
if [ ! -z "$DEVTOOLS_TOOL_FLUTTER_FROM_PATH" ]; thenI'll send a follow-up, fixing this in all places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for the process of moving devtools to the Dart SDK repo. This avoids the need to create symlinks over in that workflow. We can just use DEVTOOLS_TOOL_FLUTTER_FROM_PATH.