Add more scripts for closing-obsolete-issues skill - #9979
Open
srawlins wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces shell scripts with new Dart scripts (fetch_issues.dart and search_prs.dart) for fetching issues and searching PRs, and updates the SKILL.md documentation accordingly. The review feedback highlights a contradictory style constraint in SKILL.md caused by an accidental character replacement, and suggests robustness improvements in the Dart scripts, including validating command-line argument parsing, using idiomatic list pre-allocation, and handling potential JSON decoding exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running with an agent using the 'close-obsolete-issues' skill and it kept making ad-hoc python scripts; I asked it to check them in as Dart scripts. This should make this task faster in the future.