Skip to content

This PR is to add comments to translateCacheToNodeAffinity in fluid/pkg/ddc/alluxio/types_selector.go.#5933

Merged
cheyang merged 1 commit into
fluid-cloudnative:masterfrom
2606463451:add-comments-translate-cache-to-node-affinity
Jun 3, 2026
Merged

This PR is to add comments to translateCacheToNodeAffinity in fluid/pkg/ddc/alluxio/types_selector.go.#5933
cheyang merged 1 commit into
fluid-cloudnative:masterfrom
2606463451:add-comments-translate-cache-to-node-affinity

Conversation

@2606463451
Copy link
Copy Markdown
Contributor

I. Describe what this PR does

This PR adds function-level comments to translateCacheToNodeAffinity in fluid/pkg/ddc/alluxio/types_selector.go.

II. Does this pull request fix one issue?

fixes #5932

III. Special notes for reviews

None.

…_selector.go

Signed-off-by: liuxin <yxsj000@163.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation comments to the translateCacheToNodeAffinity function in pkg/ddc/alluxio/types_selector.go to explain its behavior, parameters, and return values. There are no review comments, and I have no feedback to provide.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented May 30, 2026

Hi @2606463451. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

@2606463451 2606463451 changed the title Add comments to translateCacheToNodeAffiThis PR is to add comments to translateCacheToNodeAffinity in fluid/pkg/ddc/alluxio/types_selector.go.nity in pkg/ddc/alluxio/types… This PR is to add comments to translateCacheToNodeAffinity in fluid/pkg/ddc/alluxio/types_selector.go. May 30, 2026
@2606463451
Copy link
Copy Markdown
Contributor Author

/assign @yangyuliufeng

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented May 30, 2026

/ok-to-test

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented May 31, 2026

/lgtm
/approve

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI checks passed and maintainer has approved. Auto-approving to satisfy branch protection.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 67f60c8 into fluid-cloudnative:master Jun 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to translateCacheToNodeAffinity in fluid/pkg/ddc/alluxio/types_selector.go.

3 participants