Record a delete reason when an error event sub-process interrupts. Fixes #4257 - #4258
Open
chaserb wants to merge 2 commits into
Open
Record a delete reason when an error event sub-process interrupts. Fixes #4257#4258chaserb wants to merge 2 commits into
chaserb wants to merge 2 commits into
Conversation
added 2 commits
August 12, 2026 17:25
The test was written to demonstrate the defect, so it read as a report of what was wrong rather than a check of what is now right. It asserts the same value either way; only the framing changes. Both new test classes were also missing the Apache license header.
filiphr
requested changes
Aug 13, 2026
Comment on lines
+31
to
+38
| class NoopDelegate implements JavaDelegate { | ||
|
|
||
| @Override | ||
| public void execute(DelegateExecution execution) { | ||
| // no-op | ||
| } | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
This shouldn't be needed. See my comment int he BPMN XMLs
| <!-- Branch B: a start execution listener raises a BpmnError. --> | ||
| <sequenceFlow id="toThrowing" sourceRef="fork" targetRef="throwingTask"/> | ||
| <serviceTask id="throwingTask" name="Throwing Task" | ||
| flowable:class="org.flowable.engine.test.api.deletereason.NoopDelegate"> |
Contributor
There was a problem hiding this comment.
Suggested change
| flowable:class="org.flowable.engine.test.api.deletereason.NoopDelegate"> | |
| flowable:expression="${true}"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 4257
ErrorPropagation.executeEventHandlerdeletes the executions an interrupting error event sub-process terminates without passing a delete reason, soACT_HI_ACTINST.DELETE_REASON_is left null and a terminated activity is indistinguishable in history from one that completed normally — which contradictsHistoricActivityInstance#getDeleteReason(), whose javadoc states that no reason is set precisely when an activity completes normally. Every other interrupting event sub-process start type recordsDeleteReason.EVENT_SUBPROCESS_INTERRUPTING, and boundary events recordBOUNDARY_EVENT_INTERRUPTING; the error start is the only one that does not. This passes that same reason at both call sites, and adds theDeleteReasonTestcase that was missing for this start type.Check List: