Skip to content

feat: spellcheck and suggestions#1362

Open
andrinoff wants to merge 2 commits into
floatpane:masterfrom
andrinoff:feat/spellcheck
Open

feat: spellcheck and suggestions#1362
andrinoff wants to merge 2 commits into
floatpane:masterfrom
andrinoff:feat/spellcheck

Conversation

@andrinoff
Copy link
Copy Markdown
Member

@andrinoff andrinoff commented May 25, 2026

What?

Adds spellcheck library, dict CLI command, suggestions, and more

Why?

Closes #1160

@LeaWhoCodes @andrinoff
@andriy-chernov @steveevansdev
feat: spellcheck and suggestions
9d535d2 
Co-authored-by: Drew Smirnoff <drew@floatpane.com>
Co-authored-by: Andriy Chernov <andriy@floatpane.com>
Co-authored-by: Steve Evans <steve@floatpane.com>
@andrinoff andrinoff requested a review from a team as a code owner May 25, 2026 14:31
@floatpanebot floatpanebot added area/tui Terminal UI / view layer area/i18n Localization / translations enhancement New feature or request area/config Configuration / settings area/cli CLI flags / commands area/docs Docs site / README size/XL Diff: 800+ lines and removed enhancement New feature or request area/tui Terminal UI / view layer area/i18n Localization / translations area/config Configuration / settings area/cli CLI flags / commands area/docs Docs site / README labels May 25, 2026
@floatpanebot
Copy link
Copy Markdown
Member

floatpanebot commented May 25, 2026

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff andrinoff added enhancement New feature or request area/tui Terminal UI / view layer area/i18n Localization / translations area/cli CLI flags / commands area/docs Docs site / README labels May 25, 2026
@andrinoff
make lint
d6bc2bc 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot
Copy link
Copy Markdown
Member

floatpanebot commented May 25, 2026 •
edited
Loading

Benchmark report — no significant change

Metrics worse: 0 · better: 0 (threshold: ±3%).

benchstat output 
goos: linux
goarch: amd64
pkg: github.com/floatpane/matcha/backend
cpu: AMD EPYC 7763 64-Core Processor                
                           │    old.txt     │              new.txt               │
                           │     sec/op     │    sec/op     vs base              │
ParseSearchQuery_Simple-4     2.742µ ±  24%   2.879µ ± 28%       ~ (p=0.394 n=6)
ParseSearchQuery_Complex-4   11.735µ ±  56%   8.242µ ± 19%       ~ (p=0.485 n=6)
TokenizeSearchQuery-4         4.086µ ± 152%   4.627µ ± 30%       ~ (p=0.937 n=6)
geomean                       5.085µ          4.788µ        -5.83%

                           │  old.txt   │              new.txt               │
                           │    B/op    │    B/op     vs base                │
ParseSearchQuery_Simple-4    26.00 ± 0%   26.00 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   762.0 ± 0%   762.0 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        176.0 ± 0%   176.0 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      151.6        151.6       +0.00%
¹ all samples are equal

                           │  old.txt   │              new.txt               │
                           │ allocs/op  │ allocs/op   vs base                │
ParseSearchQuery_Simple-4    2.000 ± 0%   2.000 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   23.00 ± 0%   23.00 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        9.000 ± 0%   9.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      7.453        7.453       +0.00%
¹ all samples are equal

pkg: github.com/floatpane/matcha/tui
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
LogPanelView-4        180.5µ ± 10%   180.7µ ± 14%       ~ (p=0.937 n=6)
SearchOverlayView-4   194.5µ ±  6%   183.8µ ± 13%       ~ (p=0.394 n=6)
InboxConstruction-4   899.8µ ± 22%   835.5µ ± 20%       ~ (p=0.818 n=6)
geomean               316.1µ         302.8µ        -4.22%

                    │    old.txt    │               new.txt               │
                    │     B/op      │     B/op       vs base              │
LogPanelView-4        44.67Ki ± 51%   44.67Ki ± 51%       ~ (p=1.000 n=6)
SearchOverlayView-4   56.14Ki ± 41%   56.15Ki ± 41%       ~ (p=0.242 n=6)
InboxConstruction-4   874.0Ki ±  0%   874.0Ki ±  0%       ~ (p=0.784 n=6)
geomean               129.9Ki         129.9Ki        +0.00%

                    │   old.txt   │              new.txt              │
                    │  allocs/op  │  allocs/op   vs base              │
LogPanelView-4         714.0 ± 0%    714.0 ± 0%       ~ (p=1.000 n=6)
SearchOverlayView-4    926.0 ± 0%    926.0 ± 0%       ~ (p=0.727 n=6)
InboxConstruction-4   3.476k ± 0%   3.476k ± 0%       ~ (p=1.000 n=6)
geomean               1.320k        1.320k       +0.00%

auto-generated by benchmarks.yml

@floatpanebot floatpanebot added the area/config Configuration / settings label May 25, 2026
@floatpanebot
Copy link
Copy Markdown
Member

floatpanebot commented May 25, 2026

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff
Copy link
Copy Markdown
Member Author

andrinoff commented May 25, 2026

i'll fix lint later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/cli CLI flags / commands area/config Configuration / settings area/docs Docs site / README area/i18n Localization / translations area/tui Terminal UI / view layer enhancement New feature or request size/XL Diff: 800+ lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FEAT: Spell-check in composer

3 participants

@andrinoff @floatpanebot @LeaWhoCodes