fix(view): sanitize HTML rendering#1361
Open
FromSi wants to merge 2 commits into
Open
Conversation
Member
Benchmark report — no significant changeMetrics worse: 0 · better: 0 (threshold: ±3%). benchstat outputauto-generated by benchmarks.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
HTML email rendering now sanitizes untrusted content before converting it to terminal text.
Available after sanitization:
http,https,mailto, andtelhttp,https, safecid, and validdata:imagepayloadsNot available after sanitization:
javascript:,vbscript:,file:, relative, and protocol-relative linksdata:orcid:links in<a href>onclick, and unsafe attributescid:anddata:imagesourcesDemo of the fix:

Why?
Closes #653
HTML emails could include unsafe links or attributes such as
javascript:URLs andon*event handlers. In terminals with OSC 8 hyperlink support, these could become risky clickable terminal links.This hardens HTML rendering for untrusted email content and addresses.
Demo of the issue:
