verify: REST in_reply_to + pending review の挙動検証(merge 予定なし)#128
Closed
flexphere wants to merge 1 commit into
Closed
verify: REST in_reply_to + pending review の挙動検証(merge 予定なし)#128flexphere wants to merge 1 commit into
flexphere wants to merge 1 commit into
Conversation
PR #127 の検証用に作成した一時ブランチ。 REST `POST /pulls/{pr}/comments` + `in_reply_to` パラメータが pending review 中に動作するかを確認するための足場。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
検証完了。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目的
PR #127 で実装した GraphQL ベースの reply 経路が必要かどうかを再検証する。
検証対象: `POST /pulls/{pr}/comments` + `in_reply_to` パラメータ が pending review 存在下で 422 を返すか、それとも動作するか。
期待される結果(仮説)
REST API 内部では reply 系も「新規 review を作成する」経路を通るため 422(user_id can only have one pending review per pull request)になると予想。
検証で 422 確定 → PR #127 を採用。
万が一動作 → PR #127 を簡略化する余地あり。
注意
このブランチは検証専用で merge する予定はない。検証後は close & delete する。
Generated with Claude Code