Add unit tests covering GCP measurement computation and a CI script to run them#1
Open
ameba23 wants to merge 3 commits intoflashbots:mainfrom
Open
Add unit tests covering GCP measurement computation and a CI script to run them#1ameba23 wants to merge 3 commits intoflashbots:mainfrom
ameba23 wants to merge 3 commits intoflashbots:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds test coverage for measurement computation for GCP. It checks hashes of a known OS image against observed measurement values from a deployment of that image, using a static hash of GCP firmware associated with the observed MRTD to avoid doing a network fetch during the test.
It also adds a CI script to run tests and a nix flake to add required dependencies for building with the
azurefeature enabled.I expect CI has to be enabled to run from this fork in order to test it. I haven't run it locally so there is a fairly good chance that CI wont pass as-is.