Conversation
✅ Deploy Preview for canarychecker canceled.
|
✅ Deploy Preview for flanksource-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces secret parameter support for playbooks with KMS encryption capabilities. It adds the ability to handle sensitive data like passwords and API keys securely by integrating with cloud KMS services.
Key changes:
- Added new
secretparameter type for playbooks with KMS encryption - Added documentation for AWS KMS, Azure Key Vault, and GCP KMS connections
- Updated submodule references across multiple mission-control components
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| mission-control/docs/reference/playbooks/parameters.mdx | Added documentation for the new secret parameter type |
| mission-control/docs/reference/connections/KMS/*.mdx | Created documentation pages for AWS KMS, Azure Key Vault, and GCP KMS connections |
| mission-control/docs/guide/playbooks/concepts/sensitive-data.mdx | Added comprehensive guide on handling sensitive data in playbooks |
| mission-control/docs/installation/_properties_mission_control.mdx | Added kmsConnection configuration property |
| common/src/components/Fields.jsx | Added field definitions for KMS connection types |
| modules/* | Updated submodule commits to incorporate KMS functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mission-control/docs/installation/_properties_mission_control.mdx
Outdated
Show resolved
Hide resolved
25de0cc to
71067b7
Compare
cc9515d to
4ab9d1b
Compare
| or in the helm chart: | ||
|
|
||
| ```yaml | ||
| kmsConnection: "connection://default/my-kms-key" |
There was a problem hiding this comment.
Can we update the setup guides for AWS/GCP for the creation of this key, and connection and the updates to the IAM binding needed.
This is also I think a post-setup task as it requires the ability to create the connection first
4ab9d1b to
d45f70b
Compare
11cfaa9 to
3109678
Compare
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThis PR introduces KMS (Key Management Service) integration to support encrypted secret parameters in playbooks. Changes include refactoring shared field definitions for cloud provider connections (AWS, GCP, Azure), adding three new KMS connection types, and providing comprehensive documentation for KMS setup, configuration, and usage across AWS, GCP, and Azure platforms. Changes
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3109678 to
0eaadd5
Compare
0eaadd5 to
32b7977
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@common/src/components/Fields.jsx`:
- Around line 188-191: The tenantId field object (field: "tenantId") is missing
its scheme property so the docs render an empty "Scheme" column; update the
tenantId entry in Fields.jsx to include the appropriate scheme (e.g., "string"
or "EnvVar") to match the other shared fields—choose "EnvVar" if it should map
to an environment variable or "string" for a plain string, and add scheme:
"<chosen>" to the tenantId object.
In `@mission-control/docs/guide/playbooks/concepts/sensitive-data.mdx`:
- Around line 13-15: The documentation references a missing fixture via the
fenced code block titled "http-secret-parameter.yaml" using the file= directive;
either add a new fixture file named http-secret-parameter.yaml with a
representative example (matching the intended YAML shown in the docs) into the
fixtures/playbooks directory, or update the fenced code block's file= value to
point to an existing fixture file or inline the YAML content directly in the
MDX; ensure the filename in the code block and the file= directive match the
actual fixture name so the build will include the example.
In `@mission-control/docs/installation/_gke_iam.mdx`:
- Around line 178-183: The snippet uses undefined variables PROJECT_NUMBER and
KSA_NAME; update the docs so the variables are set or iterate over service
accounts: either add explicit export lines for PROJECT_NUMBER and
KSA_NAME/NAMESPACE before the gcloud command (e.g., export PROJECT_NUMBER and
export NAMESPACE) or replace the single gcloud invocation with a loop over the
three KSA names ("mission-control-sa", "canary-checker-sa", "config-db-sa") to
run the gcloud projects add-iam-policy-binding command for each KSA_NAME; ensure
references to PROJECT_ID, PROJECT_NUMBER, NAMESPACE, and KSA_NAME in the command
match the variables you export or iterate.
4d3d23d to
835de36
Compare
|
@copilot fix merge conflicts using the latest modules |
a92c479 to
8d2480c
Compare
resolves: #423
Summary by CodeRabbit
New Features
Documentation