Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6314 +/- ##
==========================================
+ Coverage 84.03% 84.07% +0.03%
==========================================
Files 354 354
Lines 38100 38250 +150
Branches 10662 10830 +168
==========================================
+ Hits 32018 32159 +141
- Misses 5654 5663 +9
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
canova
requested changes
Sep 18, 2026
fatadel
force-pushed
the
issue-6290-follow-up
branch
from
September 21, 2026 16:03
17c4c8c to
cf16594
Compare
Extension IDs are embedded in Text marker strings, so sanitization requires marker name-specific parsing. Structured extension marker payloads make the sensitive fields explicit and remove this special case.
fatadel
force-pushed
the
issue-6290-follow-up
branch
from
September 21, 2026 16:16
cf16594 to
e51c511
Compare
canova
approved these changes
Sep 21, 2026
| } | ||
|
|
||
| export const extensionMarkerSchema: MarkerSchema = { | ||
| name: 'Extension', |
Member
There was a problem hiding this comment.
Nit: maybe something like ExtensionText, as it's still almost a Text marker but with extra extension information (so the name is not too generic).
| } | ||
| } | ||
|
|
||
| function _processExtensionTextMarkerPayload( |
Member
There was a problem hiding this comment.
Nit: _maybeProcess.. would make it explicit that it might not if it's not an extension text marker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Extension IDs are embedded in Text marker strings, so sanitization requires marker name-specific parsing. Structured extension marker payloads make the sensitive fields explicit and remove this special case.
Follow-up of #6291
Profile