Keep spinner frames out of redirected output - #278
danielgaskins wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
|
I added tests for both points. The interactive test now checks that no more frames are written after success. The redirected test checks that |
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Gates spinner animation on stderr being a TTY so redirected output emits one final status line instead of repeated control codes, with tests covering interactive and redirected paths.
Re-trigger cubic
What changed
Why
When stderr is redirected, writing a spinner frame every 80 ms creates a large stream of terminal control codes. This keeps the interactive experience while leaving redirected logs with one useful status line.
Testing
pnpm run buildpnpm run type-checkpnpm test(622 tests)Addresses the non-TTY spinner portion of #102.
Summary by cubic
Keeps spinner animation frames out of redirected stderr so redirected logs contain only the final success or failure line instead of terminal control codes every 80 ms. Animation is gated on
process.stderr.isTTY, and tests cover interactive, redirected success, redirected failure, and fallback to the latest message when no final message is provided. Addresses the non-TTY spinner portion of #102.Written for commit 75ad066. Summary will update on new commits.