Skip to content

Add ServerSpec to module exports#4894

Open
kengoon wants to merge 1 commit intofirebase:mainfrom
kengoon:patch-1
Open

Add ServerSpec to module exports#4894
kengoon wants to merge 1 commit intofirebase:mainfrom
kengoon:patch-1

Conversation

@kengoon
Copy link

@kengoon kengoon commented Mar 8, 2026

This pull request adds a new import and export for the ServerSpec class in the py/packages/genkit/src/genkit/ai/__init__.py file, making it available as part of the module's public API.

API surface update:

  • Added ServerSpec to the imports from ._server and included it in the __all__ list, making it publicly accessible from the genkit.ai module.

Checklist (if applicable):

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the genkit.ai module by exposing the ServerSpec class as part of its public interface. This change allows external modules and users to directly access and utilize ServerSpec for defining server configurations, thereby expanding the module's utility and integration capabilities.

Highlights

  • API Surface Update: Added ServerSpec to the genkit.ai module's public API by importing it from ._server and including it in the __all__ list.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • py/packages/genkit/src/genkit/ai/init.py
    • Imported ServerSpec from ._server.
    • Added ServerSpec to the __all__ list, making it publicly accessible.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds ServerSpec to the public API of the genkit.ai module. The changes are straightforward, adding the import and updating __all__ in py/packages/genkit/src/genkit/ai/__init__.py. The implementation is correct and follows the existing style of the file. I have no specific code improvement suggestions. I do note that the documentation checklist item is unchecked; since this change affects the public API, it would be beneficial to ensure relevant documentation is updated to reflect the availability and usage of ServerSpec.

@huangjeff5
Copy link
Contributor

Hey! Thanks for the pull request @kengoon! I'm wondering if you could share a bit more about the motivation behind this?

@kengoon
Copy link
Author

kengoon commented Mar 10, 2026

@huangjeff5 Genkit class has a reflection_server_spec parameter to modify the host and port for the genkit server in dev environment. So exposing ServerSpec class publicly is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Python

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants