Use explicit plugin names to prevent subtle macro processing bugs#482
Open
vazub wants to merge 1 commit intofinit-project:masterfrom
Open
Use explicit plugin names to prevent subtle macro processing bugs#482vazub wants to merge 1 commit intofinit-project:masterfrom
vazub wants to merge 1 commit intofinit-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the problem I recently encountered - no plugins were loading, even those statically compiled-in by default.
After a few days of debugging, I found out that
__FILE__macro was getting corrupted on expansion/processing, most likely due to either too long of a path (in my edge case it was something like/home/bazub/.cache/kiss/proc/9352/build/finit/src/../plugins/procps.c), or due to basename/trim processing, or some other factor.Initial mitigation idea was to change all instances to
__FILE_NAME__macro, which is supported by Clang, and GCC12+, but it proved to be inconsistent - some plugins were still unrecognized and failing.The final solution turned out to be even simpler - just use the explicit static names. Macro processing magic is completely unnecessary here, and just wastes cycles, while introducing subtle bugs in the process. KISS is the way.