Parse models without type: object as objects if they contain properties?#1705
Open
danmichaelo wants to merge 1 commit intoferdikoomen:mainfrom
Open
Parse models without type: object as objects if they contain properties?#1705danmichaelo wants to merge 1 commit intoferdikoomen:mainfrom
type: object as objects if they contain properties?#1705danmichaelo wants to merge 1 commit intoferdikoomen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #1178 (comment) :
It seems like most OpenAPI tooling supports objects to be defined implicitly, without
type: object. What do you think about supporting that in openapi-typescript-codegen too?I've tried to dig into the JSON Schema spec to find out what's the correct way to handle this case, but unsuccessfully.
I'm not sure if this PR is complete, but I've created it to start the discussion of whether implicit objects should be supported or not.