Packages (pkgsrc): add dynamic prefix discovery#2440
Open
Suyun114 wants to merge 2 commits into
Open
Conversation
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Member
|
Cleaned a bit. I'm pretty sure that this PR will break bedrock. As this PR searches
In addition, how bedrock strat handles Unless this is properly tested in bedrock, I don't think I want to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously pkgsrc detection hardcoded
/usr/pkg/pkgdb, which missed installations at non-standard prefixes (e.g./opt/pkg) and database directory layouts (e.g..pkgdb).Now
ffPackagesGetPkgsrcfinds thepkginbinary viaPATH, derives the prefix, reads<prefix>/etc/mk.confforPKG_DBDIR, and falls back to<prefix>/pkgdb. Analogous toffPackagesGetNix, the function appends tobaseDirfor Bedrock Linux compatibility.Support added for Linux, NetBSD, SunOS, and macOS.
Changes
src/detection/packages/packages_pkgsrc.c— shared helperpackages_linux.c/packages_apple.c/packages_nbsd.c/packages_sunos.c— all four now callffPackagesGetPkgsrcpackages.h— declaration guardedCMakeLists.txt— includes the new fileChecklist