fix: support ctrl f devtools search shortcut#36696
Conversation
|
Hi @leno23! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
Update the shared DevTools SearchInput shortcut handling so Mac keeps using Cmd+F while Windows/Linux use Ctrl+F.
This matches the platform-specific modifier handling already used by the Profiler keyboard shortcuts and fixes #26052.
How did you test this change?
git diff --checkI also attempted
yarn prettier-check packages/react-devtools-shared/src/devtools/views/SearchInput.js, but this sparse checkout has no local node_modules and Node resolved an incompatible parent chalk ESM package, so that command could not run locally.