Skip to content

fix: use == null instead of === undefined for window.event check#36692

Open
linsk1998 wants to merge 1 commit into
facebook:mainfrom
linsk1998:fix/window-event-null-check
Open

fix: use == null instead of === undefined for window.event check#36692
linsk1998 wants to merge 1 commit into
facebook:mainfrom
linsk1998:fix/window-event-null-check

Conversation

@linsk1998
Copy link
Copy Markdown

Summary

The resolveUpdatePriority function in ReactDOMUpdatePriority.js uses currentEvent === undefined to check if window.event is absent. However, window.event returns null (not undefined) in Internet Explorer 10, causing the strict equality check to fail. When this happens, getEventPriority(null.type) is called, which throws TypeError: Cannot read property 'type' of null.

Changes

  • Changed currentEvent === undefined to currentEvent == null to cover both null (IE10) and undefined (IE11)
  • Added a comment documenting the browser behavior difference

Browser Compatibility

Browser window.event value
Modern browsers undefined (when no event is being handled)
IE11 undefined
IE10 null

Using == null (loose equality) correctly handles both cases, as it matches both null and undefined.

…esolveUpdatePriority

window.event returns null in IE10, not just undefined in IE11. Using === undefined misses the null case, causing getEventPriority(null.type) to throw. Changed to == null to cover both null and undefined.
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Jun 5, 2026

Hi @linsk1998!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant