fix: use == null instead of === undefined for window.event check#36692
fix: use == null instead of === undefined for window.event check#36692linsk1998 wants to merge 1 commit into
Conversation
…esolveUpdatePriority window.event returns null in IE10, not just undefined in IE11. Using === undefined misses the null case, causing getEventPriority(null.type) to throw. Changed to == null to cover both null and undefined.
|
Hi @linsk1998! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
The
resolveUpdatePriorityfunction inReactDOMUpdatePriority.jsusescurrentEvent === undefinedto check ifwindow.eventis absent. However,window.eventreturnsnull(notundefined) in Internet Explorer 10, causing the strict equality check to fail. When this happens,getEventPriority(null.type)is called, which throwsTypeError: Cannot read property 'type' of null.Changes
currentEvent === undefinedtocurrentEvent == nullto cover bothnull(IE10) andundefined(IE11)Browser Compatibility
window.eventvalueundefined(when no event is being handled)undefinednullUsing
== null(loose equality) correctly handles both cases, as it matches bothnullandundefined.