Bail out on using declarations in HIR#36691
Open
magic-akari wants to merge 1 commit into
Open
Conversation
Emit Todo diagnostics for using and await using declarations instead of silently treating them as ordinary const declarations. Enable explicit resource management parsing in compiler test entrypoints and add snap fixtures covering using and await using bailouts.
magic-akari
force-pushed
the
fix/react-compiler-using
branch
from
2aae954 to
5aaa84a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emit Todo diagnostics for using and await using declarations instead of silently treating them as ordinary const declarations. Enable explicit resource management parsing in compiler test entrypoints and add snap fixtures covering using and await using bailouts.
usingsyntax is not preserved #35171Snapshots
The
usingsyntax now throws an expected error, consistent with the behavior ofvar.How did you test this change?