Skip to content

Conversation

@Programlog
Copy link

Summary

This PR contains small code quality improvements and cleanup across the React codebase.

Changes

  1. Remove obsolete error code 355 for useOpaqueIdentifier

    • This error was for a feature that was never released
    • The error message itself contained a TODO: "This feature was never released so we should be able to remove this error from the map"
    • Confirmed no other references to this error code exist in the codebase
  2. Improve @deprecated documentation for noEmit compiler option

    • Clarify the migration path to use outputMode instead
    • Updated terminology from "Forget" to "the compiler" for consistency
    • Made the deprecation notice more actionable
  3. Remove stale TODO comment from ReactNative.js shim

    • The TODO suggested deleting the "legacy renderer" but this shim is still required for backward compatibility
    • Removing the misleading comment prevents confusion

Test Plan

These are documentation and dead code removal changes that don't affect runtime behavior:

  • Error code 355 was for an unreleased feature and has no usages
  • The noEmit option behavior is unchanged, only JSDoc improved
  • The ReactNative.js shim behavior is unchanged, only comment removed

- Remove obsolete error code 355 for useOpaqueIdentifier
  This error was for a feature that was never released, as noted in the
  TODO comment within the error message itself.

- Improve @deprecated documentation for noEmit compiler option
  Clarify the migration path to outputMode and update terminology from
  'Forget' to 'the compiler'.

- Remove stale TODO comment from ReactNative.js shim
  The comment suggested deleting the legacy renderer, but this shim is
  still needed for backward compatibility.
@meta-cla
Copy link

meta-cla bot commented Jan 19, 2026

Hi @Programlog!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla
Copy link

meta-cla bot commented Jan 19, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant