[Android] [Fixed] - Fix fontVariant stylistic sets being ignored in New Architecture

[dragoncodes]

Summary:

During an upgrade of ReactNative and switching to new arch, we noticed that Android is ignoring some fontVariants. Specifically stylistic-{num}. Digging further I noticed that there are stylistic-{num} mappings added to fromRawValue (in packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h), but are not included for toMapBuffer

Changelog:

[Android] [Fixed] - fontVariants stylistic-{num} not being propagated correctly

Test Plan:

• Added a new free font (FiraCode) that has stylistic features.
• Added Text examples for Android showing with and without stylistic features

Before and after in order:

[meta-cla]

Hi @dragoncodes!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[meta-codesync]

@philIip has imported this pull request. If you are a Meta employee, you can view this in D90830140.

[cortinico]

Review automatically exported from Phabricator review in Meta.

[cortinico]

LGTM 👍 Thanks for adding a sample to RN Tester also

[dragoncodes]

Awesome, I'll now look into the failing checks 👀

[react-native-bot]

This pull request was successfully merged by @dragoncodes in 9353eb5

^{When will my fix make it into a release? | How to file a pick request?}

[meta-codesync]

@philIip merged this pull request in 9353eb5.

[philIip]

couple changes i made you can see in 9353eb5:

• needed to add the resource xml to wire to the ttf
• split out the regular font, the one provided was a variable font