-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Remove unnecessary references to global from the react-native package #55166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rubennorte
wants to merge
2
commits into
facebook:main
Choose a base branch
from
rubennorte:export-D90603719
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+652
−206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90603719. |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 15, 2026
…facebook#55166) Summary: Pull Request resolved: facebook#55166 Changelog: [internal] The use of the `global` namespace is unnecessary when accessing built-in globals (they're always defined) so we can remove the prefix, very slightly improving readability and performance. Reviewed By: yungsters Differential Revision: D90603719
ef6c692 to
f20ff68
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 15, 2026
…facebook#55166) Summary: Pull Request resolved: facebook#55166 Changelog: [internal] The use of the `global` namespace is unnecessary when accessing built-in globals (they're always defined) so we can remove the prefix, very slightly improving readability and performance. Reviewed By: yungsters Differential Revision: D90603719
f20ff68 to
d5855e8
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 19, 2026
…facebook#55166) Summary: Pull Request resolved: facebook#55166 Changelog: [internal] The use of the `global` namespace is unnecessary when accessing built-in globals (they're always defined) so we can remove the prefix, very slightly improving readability and performance. Reviewed By: yungsters Differential Revision: D90603719
d5855e8 to
dbb713b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 20, 2026
…facebook#55166) Summary: Pull Request resolved: facebook#55166 Changelog: [internal] The use of the `global` namespace is unnecessary when accessing built-in globals (they're always defined) so we can remove the prefix, very slightly improving readability and performance. Reviewed By: yungsters Differential Revision: D90603719
dbb713b to
c664c66
Compare
…module Differential Revision: D90588265
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 22, 2026
…facebook#55166) Summary: Pull Request resolved: facebook#55166 Changelog: [internal] The use of the `global` namespace is unnecessary when accessing built-in globals (they're always defined) so we can remove the prefix, very slightly improving readability and performance. Reviewed By: yungsters Differential Revision: D90603719
c664c66 to
2e3ee8a
Compare
…facebook#55166) Summary: Pull Request resolved: facebook#55166 Changelog: [internal] The use of the `global` namespace is unnecessary when accessing built-in globals (they're always defined) so we can remove the prefix, very slightly improving readability and performance. Reviewed By: yungsters Differential Revision: D90603719
2e3ee8a to
27421f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
meta-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
The use of the
globalnamespace is unnecessary when accessing built-in globals (they're always defined) so we can remove the prefix, very slightly improving readability and performance.Differential Revision: D90603719