Conversation
Damage Accumulation Rule according to Palmgren-Miner * src/fatpy/core/damage_cumulationdamage_cumulation_palmgren_meiner.py * tests/core/test_src/fatpy/core/damage_cumulation/test_damage_cumulation.py
LCF uniaxial SWT criterion * src/fatpy/core/energy_life/damage_parameters.py * tests/energy_life/test_damage_parameters.py file `demage_parameters.py` renamed to `damage_parameters.py`.
Vybornak2
left a comment
There was a problem hiding this comment.
PR contains both SWT and DMG Cumulation. Should be split.
Required structure:
Only STW will be commented:
According to architecture meeting both calculation of SWT DMG PARAM and LIFE based on SWT DMG PARAM should be exposed.
Required functions:
calc_dmg_param_SWT()calc_life_SWT()
Note: names are yet to be decided, but I propose ones that I mentioned.
Vectorization
Functions should accept ArrayLike as input.
This allows both floats and arrays.
Output should be np.NDArray - meaning entities would be converted to arrays. What do you think? (either generic of python 3.12 or concrete type)
Solution should be such that would allow broadcasting to any amount of dimensions. (e.g. user might decide to have arrays reflecting different layers, materials, model parts using multiple dimensions)
Damage Accumulation Rule according to Palmgren-Miner
src/fatpy/core/damage_cumulationdamage_cumulation_palmgren_meiner.pytests/core/test_src/fatpy/core/damage_cumulation/test_damage_cumulation.pyFIle
src/fatpy/core/energy_life/demage_parameters.pywas misspelled.