fix: prevent path traversal in view lookup#7217
Closed
kuishou68 wants to merge 1 commit intoexpressjs:masterfrom
Closed
fix: prevent path traversal in view lookup#7217kuishou68 wants to merge 1 commit intoexpressjs:masterfrom
kuishou68 wants to merge 1 commit intoexpressjs:masterfrom
Conversation
Adds a containment check so relative view names cannot escape the
configured views root via '../' traversal. Absolute paths are
intentionally excluded from the check to preserve existing Express
behavior (app.render('/abs/path') is a documented feature).
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a path traversal vulnerability in
View.prototype.lookupwhere a relative view name containing../sequences could resolve to files outside the configuredviewsroot directories.Problem
Fix
Added a containment check after path resolution: if the resolved path does not start with the root directory prefix, the lookup is skipped for that root. Absolute paths are intentionally excluded from the check to preserve existing Express behavior (
app.render('/absolute/path')is supported).Testing
All existing tests pass (
npm test). The fix preserves:viewsroots (array)app.render('/abs/path'))