Skip to content

fix: restore array parsing for req.query repeated keys (#7147) #7181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonchurch merged 2 commits into from
May 8, 2026
+16 −1
Merged

fix: restore array parsing for req.query repeated keys (#7147) #7181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0b4eaa
fix: restore array parsing for `req.query` repeated keys (#7147)
SAY-5 Apr 15, 2026
f0a137e
chore: drop comment and issue refrences, drop sparse array test
jonchurch Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ function createETagGenerator (options) {

function parseExtendedQueryString(str) {
return qs.parse(str, {
allowPrototypes: true
allowPrototypes: true,
arrayLimit: 1000
Comment thread
jonchurch marked this conversation as resolved.
});
}

Expand Down
14 changes: 14 additions & 0 deletions test/req.query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,20 @@ describe('req', function(){
.get('/?user.name=tj')
.expect(200, '{"user.name":"tj"}', done);
});

it('should parse more than 20 repeated values as an array', function (done) {
var app = createApp('extended');
var ids = [];
var expected = [];
for (var i = 0; i < 25; i++) {
ids.push('ids=' + i);
expected.push(String(i));
}

request(app)
.get('/?' + ids.join('&'))
.expect(200, JSON.stringify({ ids: expected }), done);
});
});

describe('when "query parser" is simple', function () {
Expand Down
Loading