Change res.flush to accept a callback function argument#227
Merged
bjohansebas merged 4 commits intov2from Apr 16, 2025
Merged
Conversation
bjohansebas
force-pushed
the
bijoythomas/master
branch
from
6215535 to
48f195c
Compare
| function write () { | ||
| chunks++ | ||
| if (chunks === 20) return resp.end() | ||
| if (chunks > 20) return chunks-- |
There was a problem hiding this comment.
The use of a decrement operator within the return statement to handle chunk overflow is ambiguous and may lead to unintended behavior. Consider revising the logic with an explicit conditional check to prevent writing beyond the intended chunk count.
Suggested change
| if (chunks > 20) return chunks-- | |
| if (chunks > 20) { | |
| chunks--; | |
| return; | |
| } |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
Author
|
Since this was already reviewed in #57, I'm going to merge it and it's all good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, #57 has maintainer edits disabled, so I created this PR with @bijoythomas's changes and added tests for Brotli :)
Closes #57