refactor: use res.headersSent#225
Merged
bjohansebas merged 1 commit intoexpressjs:v2from Apr 8, 2025
bjohansebas:refactor
Merged
refactor: use res.headersSent#225bjohansebas merged 1 commit intoexpressjs:v2from bjohansebas:refactor
bjohansebas merged 1 commit intoexpressjs:v2from
bjohansebas:refactor
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
index.js:93
- Consider adding tests to verify that cases where res.headersSent is true are correctly handled, ensuring the refactored behavior works as expected on supported Node.js versions.
if (!res.headersSent) {
Phillip9587
approved these changes
Apr 7, 2025
UlisesGascon
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer support older versions, and it's not advisable to use undocumented APIs.