Fix git-ref --since including the tagged merge PR - #178
Open
BetterAndBetterII wants to merge 1 commit into
Open
Conversation
When --since is a git tag, treat the activity window as exclusive of the tagged merge timestamp so the release PR itself is not listed again in the next changelog (Fixes executablebooks#79). Calendar-date --since stays inclusive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--sinceas a git tag was inclusive of the tagged merge timestamp, so a PR whose merge commit is that tag was listed again in the next changelog. GitHub comparetag...HEADdoes not include that commit.Git-ref
--sinceis now exclusive of the tagged merge. A calendar-date--sincestays inclusive.Fixes #79
Test plan
pytest tests/test_activity_window.py --no-covv3.0.5shape from Pull requests that happen on the same date as a release are always included even if they happened outside the window of the release #79--sinceremains inclusive